fix: extract text from React elements in slugifyMarkdownHeadline to fix code-wrapped heading anchors#2349
Closed
Divyansh200102 wants to merge 1 commit intojson-schema-org:mainfrom
Closed
Conversation
…ix code-wrapped heading anchors
|
Hi @Divyansh200102! Thanks a lot for your contribution! I noticed that the following required information is missing or incomplete: completed checklist items Please update the PR description to include this information. You can find placeholders in the PR template for these items. Thanks a lot! |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2349 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 30 30
Lines 672 672
Branches 211 211
=========================================
Hits 672 672 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
github-project-automation
bot
moved this from Ready to review
to Done
in PR - Triage Group
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bugfix
Issue Number:
Screenshots/videos:
(see issue #2341 for reproduction video)
After
Summary
Section headers wrapped in backticks (e.g.
#### `Schema`) were rendered bymarkdown-to-jsxas React<code>elements, not plain strings.slugifyMarkdownHeadlineonly handled string children, so it returned""for these headings — causinghref="#"in the ToC (scroll to top) and"" === ""matching all headings at once (all highlighted).Added
extractTextFromNodeto recursively extract text from React elements, so`Schema`now correctly produces the slugschema.Does this PR introduce a breaking change?
No.
Checklist